fix: implement all issues #3-#9 + UI improvements#10
Merged
Conversation
- #3: EchoCanceller uses pre-allocated buffer (no heap alloc per frame) - #4/#5: Migrate LV2 and NIH-plug to ringbuf 0.4 API - #6: Remove unused _accent_color in theme.rs - #7: Reject incompatible sample rates in plugin init - #8: Update README with Windows/macOS virtual device setup - #9: Clear placeholder email in plugin metadata Closes #3, #4, #5, #6, #7, #8, #9
- VAD combo box: refactored repetitive code to loop (35→15 lines) - Light mode: added proper color palette matching dark mode quality - Theme constants: extracted ACCENT_BLUE, SUCCESS_GREEN, etc. - Tooltips: added to Auto-Gate, AGC, VAD, jitter indicators - Visualizer: improved input line visibility (faint red→clear red) - Jitter: extracted JITTER_GOOD_US/WARN_US constants - EQ: refactored to Grid layout for aligned sliders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements fixes for GitHub issues #3-#9 and adds 8 UI improvements.
Fixes
UI Improvements
Closes #3, #4, #5, #6, #7, #8, #9